Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix @Mock(serializable = true) for parameterized types. #3007

Merged
merged 1 commit into from May 8, 2023

Conversation

cpovirk
Copy link
Contributor

@cpovirk cpovirk commented May 8, 2023

Fixes #2979

Checklist

  • Read the contributing guide
  • PR should be motivated, i.e. what does it fix, why, and if relevant how
  • If possible / relevant include an example in the description, that could help all readers
    including project members to get a better picture of the change
  • Avoid other runtime dependencies
  • Meaningful commit history ; intention is important please rebase your commit history so that each
    commit is meaningful and help the people that will explore a change in 2 years
  • The pull request follows coding style
  • Mention Fixes #<issue number> in the description if relevant
  • At least one commit should mention Fixes #<issue number> if relevant

@codecov-commenter
Copy link

codecov-commenter commented May 8, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (6e0c228) 85.70% compared to head (080674f) 85.70%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #3007   +/-   ##
=========================================
  Coverage     85.70%   85.70%           
  Complexity     2876     2876           
=========================================
  Files           326      326           
  Lines          8733     8733           
  Branches       1078     1078           
=========================================
  Hits           7485     7485           
  Misses          971      971           
  Partials        277      277           
Impacted Files Coverage Δ
...o/internal/creation/settings/CreationSettings.java 96.49% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@TimvdLippe TimvdLippe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@TimvdLippe TimvdLippe merged commit 7d53c57 into mockito:main May 8, 2023
13 checks passed
@cpovirk cpovirk deleted the serializableparameterized branch May 8, 2023 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@Mock(serializable = true) no longer works with parameterized types
3 participants