New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewire Jacoco for Gradle 8/9 #3052
Merged
Merged
Commits on Jul 4, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 3289451 - Browse repository at this point
Copy the full SHA 3289451View commit details -
Apply jacoco plugin to allprojects fully
The jacoco plugin was applied on the wrong Project object which lead to multiple workarounds: * somehow `apply plugin:` binds to the script default project which is rootProject * so the plugin wasn't applied to currentProject * so it didn't register .jacoco on the Test tasks * so manual `applyTo()` was required * calling `applyTo test` resolved to `rootProject.jacoco.applyTo(currentProject.tasks.test)` (because the currentProject.jacoco wasn't registered!) * which lead to a cross-project configuration leak, and we had the warning: > Task :*:test Resolution of the configuration :jacocoAgent was attempted from a context different than the project context. Have a look at the documentation to understand why this is a problem and how it can be resolved. This behavior has been deprecated. This will fail with an error in Gradle 9.0. For more information, please refer to https://docs.gradle.org/8.2/userguide/viewing_debugging_dependencies.html#sub:resolving-unsafe-configuration-resolution-errors in the Gradle documentation.
Configuration menu - View commit details
-
Copy full SHA for d40619f - Browse repository at this point
Copy the full SHA d40619fView commit details -
Do not set jacoco path which is the same as the default.
Because of the manual applyTo() call the project object was always rootProject which set the wrong destinationFile and tasks overwrote each others' outputs. The workaround to manually split these files is no longer necessary after the previous commit.
Configuration menu - View commit details
-
Copy full SHA for 2eb2129 - Browse repository at this point
Copy the full SHA 2eb2129View commit details -
Configuration menu - View commit details
-
Copy full SHA for 30037de - Browse repository at this point
Copy the full SHA 30037deView commit details -
Configuration menu - View commit details
-
Copy full SHA for dd2d6bd - Browse repository at this point
Copy the full SHA dd2d6bdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4c6ceb6 - Browse repository at this point
Copy the full SHA 4c6ceb6View commit details -
Configuration menu - View commit details
-
Copy full SHA for db20a4b - Browse repository at this point
Copy the full SHA db20a4bView commit details -
Configuration menu - View commit details
-
Copy full SHA for cdc8bd6 - Browse repository at this point
Copy the full SHA cdc8bd6View commit details
Commits on Jul 5, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 97151b0 - Browse repository at this point
Copy the full SHA 97151b0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1a79f98 - Browse repository at this point
Copy the full SHA 1a79f98View commit details -
Configuration menu - View commit details
-
Copy full SHA for d430fcb - Browse repository at this point
Copy the full SHA d430fcbView commit details -
Configuration menu - View commit details
-
Copy full SHA for eaf7d4e - Browse repository at this point
Copy the full SHA eaf7d4eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 17f4b5f - Browse repository at this point
Copy the full SHA 17f4b5fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7dc3fb7 - Browse repository at this point
Copy the full SHA 7dc3fb7View commit details
Commits on Jul 7, 2023
-
Configuration menu - View commit details
-
Copy full SHA for a403bc2 - Browse repository at this point
Copy the full SHA a403bc2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 32a12a9 - Browse repository at this point
Copy the full SHA 32a12a9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 220029c - Browse repository at this point
Copy the full SHA 220029cView commit details
Commits on Jul 8, 2023
-
Configuration menu - View commit details
-
Copy full SHA for b60e1bb - Browse repository at this point
Copy the full SHA b60e1bbView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.