Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewire Jacoco for Gradle 8/9 #3052

Merged
merged 18 commits into from Jul 8, 2023
Merged

Commits on Jul 4, 2023

  1. Configuration menu
    Copy the full SHA
    3289451 View commit details
    Browse the repository at this point in the history
  2. Apply jacoco plugin to allprojects fully

    The jacoco plugin was applied on the wrong Project object which lead to multiple workarounds:
     * somehow `apply plugin:` binds to the script default project which is rootProject
     * so the plugin wasn't applied to currentProject
     * so it didn't register .jacoco on the Test tasks
     * so manual `applyTo()` was required
     * calling `applyTo test` resolved to `rootProject.jacoco.applyTo(currentProject.tasks.test)` (because the currentProject.jacoco wasn't registered!)
     * which lead to a cross-project configuration leak, and we had the warning:
    
    > Task :*:test
    Resolution of the configuration :jacocoAgent was attempted from a context different than the project context. Have a look at the documentation to understand why this is a problem and how it can be resolved. This behavior has been deprecated. This will fail with an error in Gradle 9.0. For more information, please refer to https://docs.gradle.org/8.2/userguide/viewing_debugging_dependencies.html#sub:resolving-unsafe-configuration-resolution-errors in the Gradle documentation.
    TWiStErRob committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    d40619f View commit details
    Browse the repository at this point in the history
  3. Do not set jacoco path which is the same as the default.

    Because of the manual applyTo() call the project object was always rootProject which set the wrong destinationFile and tasks overwrote each others' outputs. The workaround to manually split these files is no longer necessary after the previous commit.
    TWiStErRob committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    2eb2129 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    30037de View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    dd2d6bd View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    4c6ceb6 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    db20a4b View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    cdc8bd6 View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2023

  1. Configuration menu
    Copy the full SHA
    97151b0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1a79f98 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    d430fcb View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    eaf7d4e View commit details
    Browse the repository at this point in the history
  5. Fix path

    TWiStErRob committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    17f4b5f View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    7dc3fb7 View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2023

  1. Configuration menu
    Copy the full SHA
    a403bc2 View commit details
    Browse the repository at this point in the history
  2. Turn off verbosity

    TWiStErRob committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    32a12a9 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    220029c View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2023

  1. Configuration menu
    Copy the full SHA
    b60e1bb View commit details
    Browse the repository at this point in the history