Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gradle build script improvements #3062

Merged
merged 10 commits into from Jul 15, 2023
Merged

Gradle build script improvements #3062

merged 10 commits into from Jul 15, 2023

Commits on Jul 14, 2023

  1. Convert build.gradle.kts outliers back to build.gradle to be consistent 

    It also needs more hacky code than benefits.
Builds will be faster too.
    @TWiStErRob
    TWiStErRob committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    fa33699 View commit details
    Browse the repository at this point in the history

  2. Remove unnecessary inclusion of dead repositories

    @TWiStErRob
    TWiStErRob committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    9d0a38b View commit details
    Browse the repository at this point in the history

  3. Remove dead repository, mavenLocal() is not used, because we depend o… 

    …n project() objects.

Even if it was, a repositories {} inside a build.gradle file doesn't override, it appends (confirmed with `println(repositories.collect())` before and after the block; so globally declared repos might win in resolution.
    @TWiStErRob
    TWiStErRob committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    f061e50 View commit details
    Browse the repository at this point in the history

  4. Remove unused dependency

    @TWiStErRob
    TWiStErRob committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    f73491b View commit details
    Browse the repository at this point in the history

  5. Generalize ordering of build.gradle headings: 

    imports
plugins { }
apply from:
description
dependencies
... everything else

and make plugin syntax consistent.

Also fix ordering dependency on description being set before including a file.
    @TWiStErRob
    TWiStErRob committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    bc8272f View commit details
    Browse the repository at this point in the history

  6. Add missing dependencies.gradle inclusions

    @TWiStErRob
    TWiStErRob committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    343c3b0 View commit details
    Browse the repository at this point in the history

  7. Format

    @TWiStErRob
    TWiStErRob committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    50aea48 View commit details
    Browse the repository at this point in the history

  8. Introduce new module type: java-test 

    Change: junitJupiterExtensionTest and junitJupiterInlineMockMakerExtensionTest had the javadoc task enabled.
    @TWiStErRob
    TWiStErRob committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    3dc1d62 View commit details
    Browse the repository at this point in the history

  9. Add java version to new module type: java-test 

    Change: memory-test, osgi-test, junitJupiterExtensionTest and junitJupiterInlineMockMakerExtensionTest had no java compatibility declared, now it's 11.
    @TWiStErRob
    TWiStErRob committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    69ea04a View commit details
    Browse the repository at this point in the history

  10. Nominate more modules as java-test. 

    Change: extTest, junitJupiterParallelTest, groovyTest, groovyInlineTest had no java compatibility declared, now it's 11.

Change: extTest, junitJupiterParallelTest, groovyTest, groovyInlineTest, kotlinReleaseCoroutinesTest and kotlinTest had the javadoc task enabled.
    @TWiStErRob
    TWiStErRob committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    4c303f9 View commit details
    Browse the repository at this point in the history