Fixes #3061 : Deprecated mockedTypeIsInconsistentWithDelegatedInstance() #3159
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves issue #3061.
Initially I thought it would be possible to replace the delegatedInstance() reference. However, investigating the origins of the mockTypeIsInconsistentWithDelegatedInstance exception, it seems to me that the exception is not needed. It is only thrown in the validateDelegatedInstance method, and this method is never called anywhere in the codebase. Thus, the exception can be deprecated.
This will avoid any further confusion with the delegatedInstance() reference.
This is my first ever pull request, so any feedback is greatly appreciated.
Checklist
including project members to get a better picture of the change
commit is meaningful and help the people that will explore a change in 2 years
Fixes #<issue number>
in the description if relevantFixes #<issue number>
if relevant