ArgumentCaptor and ArgumentMatchers can now mixed in varargs

[ChristianSchwarz]

fixes #439

• ArgumentCaptor and ArgumentMatchers can now mixed in varargs
• added 25 regression tests in VarargsTest (5 are ignored cause they belong to other issues and fail currently)
• refactored InvocationMatcher:
  • removed duplicates and unneccesary code
  • simplified the logic as much as possible
  • moved caputing logic to InvocationArgumentCaptor (if you have a better name let me know)

[codecov-io]

Current coverage is 88.23% (diff: 93.93%)

Merging #613 into master will decrease coverage by <.01%

@@             master       #613   diff @@
==========================================
  Files           266        267     +1   
  Lines          5161       5175    +14   
  Methods           0          0          
  Messages          0          0          
  Branches        847        848     +1   
==========================================
+ Hits           4554       4566    +12   
- Misses          429        431     +2   
  Partials        178        178          

Powered by Codecov. Last update b669b4f...88b6574

[mockitoguy]

Great PR:

• it neatly describes the high level design - I don't need to look into the code to find out the design
• at adds tangible value to Mockito, making the library more intuitive to use. Library such as Mockito becomes great when we apply consistent effort over time and improve it one step at the time :D
• it's not a refactoring-only PR :))))

Thanks!!! Keep it coming!

[bric3]

Can you remove empty comment ?

[ChristianSchwarz]

Sure.

[bric3]

For me this code is really nice, this is definitely an improvement !
I would like however to see a unit test on InvocationArgumentCaptor this way it is easier to measure coverage overthere.

[bric3]

I will wait for the release of mockito 2.1 though before merging this one. (As you may be aware we are skipping the number 2.0 in favor of 2.1 due to semantic versioning issues we had)

[ChristianSchwarz]

@szczepiq
@bric3
Thanks for the great feedback! I am going to incorporate the requested changes during the coming week end.

[ChristianSchwarz]

I close this PR it is superseded by #635.