Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce code duplication across subprojects #857

Closed
aSemy opened this issue Jul 23, 2022 · 0 comments · Fixed by #913
Closed

Reduce code duplication across subprojects #857

aSemy opened this issue Jul 23, 2022 · 0 comments · Fixed by #913

Comments

@aSemy
Copy link
Contributor

aSemy commented Jul 23, 2022 •
edited

There is some amount of code duplication in the MockK modules. Specifically ValueClassSupport (but there might be more?)

https://github.com/mockk/mockk/blob/54e30ec66e4aeb61942b976dbb33fd37c9487629/agent/android/src/main/kotlin/io/mockk/ValueClassSupport.kt
https://github.com/mockk/mockk/blob/54e30ec66e4aeb61942b976dbb33fd37c9487629/agent/jvm/src/main/kotlin/io/mockk/ValueClassSupport.kt

Eliminating this code duplication would reduce the risk of bugs and inconsistent behaviour.

See also
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

De-duplicate ValueClassSupport aSemy/mockk
1 participant
@aSemy