Return the configured answers when no answer found #1032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Raibaz
requested changes
Jan 27, 2023
| @@ -87,7 +87,9 @@ open class MockKStub( | |||
| childMockK(invocation.allEqMatcher(), invocation.method.returnType) | |||
| } | |||
| } else { | |||
| throw MockKException("no answer found for: ${gatewayAccess.safeToString.exec { invocation.toString() }}") | |||
| val configuredAnswers = answers.map { it.matcher.toString() }.joinToString(separator = "\n") { it } | |||
| throw MockKException("no answer found for: ${gatewayAccess.safeToString.exec { invocation.toString() }}" + | |||
There was a problem hiding this comment.
I would remove the first semicolon here and replace "between" with "among"
Raibaz
approved these changes
Jan 30, 2023
hyochan
pushed a commit
to dooboolab-community/react-native-iap
that referenced
this pull request
Jun 22, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [io.mockk:mockk](https://mockk.io) ([source](https://togithub.com/mockk/mockk)) | `1.13.4` -> `1.13.5` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>mockk/mockk</summary> ### [`v1.13.5`](https://togithub.com/mockk/mockk/releases/tag/1.13.5) #### What's Changed - Return the configured answers when no answer found by [@​maeserichar](https://togithub.com/maeserichar) in [mockk/mockk#1032 - Recognize atLeast = 0 when mocked methods is never called by [@​hfxbse](https://togithub.com/hfxbse) in [mockk/mockk#970 - Update class declaration name to match with test class by [@​Sandhya2902](https://togithub.com/Sandhya2902) in [mockk/mockk#1044 - Update to Junit 5 by [@​Sandhya2902](https://togithub.com/Sandhya2902) in [mockk/mockk#1045 - Issue [#​997](https://togithub.com/mockk/mockk/issues/997) - Simulate garbage collected proxy by [@​ygaller](https://togithub.com/ygaller) in [mockk/mockk#1052 - Enable Gradle build scan publishing by [@​Goooler](https://togithub.com/Goooler) in [mockk/mockk#1060 - Added the "Top Level functions" section by [@​polarene](https://togithub.com/polarene) in [mockk/mockk#1061 - corrected incongruent code in "Object mock" by [@​polarene](https://togithub.com/polarene) in [mockk/mockk#1063 - Kotlin 1.8.20 by [@​SimonMarquis](https://togithub.com/SimonMarquis) in [mockk/mockk#1047 #### New Contributors - [@​maeserichar](https://togithub.com/maeserichar) made their first contribution in [mockk/mockk#1032 - [@​hfxbse](https://togithub.com/hfxbse) made their first contribution in [mockk/mockk#970 - [@​ygaller](https://togithub.com/ygaller) made their first contribution in [mockk/mockk#1052 - [@​Goooler](https://togithub.com/Goooler) made their first contribution in [mockk/mockk#1060 **Full Changelog**: mockk/mockk@v1.13.4...1.13.5 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/dooboolab-community/react-native-iap). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS45OC40IiwidXBkYXRlZEluVmVyIjoiMzUuMTMxLjAiLCJ0YXJnZXRCcmFuY2giOiJtYWluIn0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the way the
MockKExceptionis constructed when a mock is called with a set of parameters that wasn't configured, so it also adds to the exception message all the answers configured for that mock.The aim of this change is to help understand why is the mock's call really failing, giving some extra information to the developer.