Fix capture using mutable list of value class #1209
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Problem
When using
capture
with a mutable list of a value type (i.e. usingCaptureMatcher
), the wrapped value is captured rather than the value type:When using
capture
with aslot
(i.e. usingCapturingSlotMatcher
) this is handled by calling the internalboxCast
helper function.The Solution
Use
boxCast
inCaptureMatcher
, in the same way asCapturingSlotMatcher
does.