Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#152 support value classes #849
#152 support value classes #849
Changes from 4 commits
4c936b1
b6670b7
7da1ad8
514e014
cd368da
32ade90
0ffba57
f2e6c7a
1c5e442
9cc892f
bcd427e
201b43d
65e8643
5e7851b
ed8ab0c
aafe7af
fd6b24e
360b08e
af349e7
592bdaf
fcaef2e
8b8017c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure how to resolve this
ValueClassSupport.kt
is in projectmockk-agent-jvm
InternalPlatformDsl
is in projectmockk-dsl-jvm
I'm looking for suggestions. Maybe it's okay just to have it copy and pasted?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep i think if they are in those two separate modules there's no better way and we can live with it being copypasted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think a comment where the same functionality is implemented would help, i case that code ever needs to be updated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea, and I've made an issue to try and de-duplicated it later #857