Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

De-duplicate ValueClassSupport #913

Merged
merged 13 commits into from Sep 6, 2022

Commits on Sep 4, 2022

  1. create new module for platform implementations, and move ValueClassSu…

    …pport into it (deleting the duplicated versions in Android and DSL modules)
    aSemy committed Sep 4, 2022
    Copy the full SHA
    849712b View commit details
    Browse the repository at this point in the history
  2. update API dumps

    aSemy committed Sep 4, 2022
    Copy the full SHA
    acda8d3 View commit details
    Browse the repository at this point in the history
  3. Copy the full SHA
    7d4b31c View commit details
    Browse the repository at this point in the history
  4. update name & description

    aSemy committed Sep 4, 2022
    Copy the full SHA
    d1ce726 View commit details
    Browse the repository at this point in the history
  5. formatting

    aSemy committed Sep 4, 2022
    Copy the full SHA
    df2ccd4 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2022

  1. Copy the full SHA
    1badf45 View commit details
    Browse the repository at this point in the history
  2. refactor value class helper code to be in ValueClassSupport

    - remove InternalPlatformDsl.unboxClass util (it's the same as ValueClassSupport.boxedClass)
    - move InternalPlatformDsl.boxCast to ValueClassSupport
    aSemy committed Sep 6, 2022
    Copy the full SHA
    f45e129 View commit details
    Browse the repository at this point in the history
  3. revert boxCast refactor (while it respects value classes, it is not s…

    …pecifically for value classes, so it makes more sense to be in a general util class)
    aSemy committed Sep 6, 2022
    Copy the full SHA
    5b1f61c View commit details
    Browse the repository at this point in the history
  4. make boxCast internal again

    aSemy committed Sep 6, 2022
    Copy the full SHA
    2213135 View commit details
    Browse the repository at this point in the history
  5. Copy the full SHA
    0e9ff0c View commit details
    Browse the repository at this point in the history
  6. Copy the full SHA
    6a8ff9f View commit details
    Browse the repository at this point in the history
  7. Copy the full SHA
    8342477 View commit details
    Browse the repository at this point in the history
  8. update API dump

    aSemy committed Sep 6, 2022
    Copy the full SHA
    c986928 View commit details
    Browse the repository at this point in the history