Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code cleanup #976

Merged
merged 81 commits into from
Dec 6, 2022
Merged

Code cleanup #976

merged 81 commits into from
Dec 6, 2022

Conversation

aSemy
Copy link
Contributor

@aSemy aSemy commented Nov 16, 2022 •
edited

A lot of minor code clean up

  • remove unused imports
  • inline variables
  • make some test classes private
  • remove old api spec
  • lots of IntelliJ suggestions
  • use a few new kotlin stdlib utils

@aSemy aSemy marked this pull request as draft November 16, 2022 19:50
@aSemy
property accessor syntax
9e3f832
@aSemy
lift return out of 'if'
644cf25
@aSemy
inline val into when arg
d8c13a9
@aSemy
replace 'if' with 'when'
c272301
@aSemy
move lambda out of brackets
0c5dfd0
@aSemy
use Set for subtracting lists
11725c3
@aSemy
replace explicit types with <>
e841279
@aSemy
string template
02a9b36
@aSemy
replace assertTrue(ref1 == ref2) with assertEquals(ref1, ref2)
444c16d
@aSemy
move lambda out of fun brackets
c762655
@aSemy
remove unnecessary brackets
6db28fc
@aSemy
'GitHub' capitalize
6483354
@aSemy
set explict platform type
bddfc40
@aSemy
val can be private
586257c
@aSemy
move lambda out of fun brackets
889c0bf
@aSemy
collapse catch blocks
391962c
@aSemy
replace Any cast with type param
abb85f9
@aSemy
minor spelling fix
9c5e795
@aSemy
move kotlinDslPluginOptions to root level
b316055
@aSemy
add names to boolean args
87484b2
@aSemy
replace 'if' with 'when', replace always false 'obj1 === obj2' with '…
8d54f05 
…false'
@aSemy
rm unnecessary Any type param
b3136c4
@aSemy
Not annotated parameter overrides @NotNull parameter
d01593e
@aSemy
specify platform type explicitly
2b1863f
@aSemy
redundant Unit return
e5664b2
@aSemy
spelling github GitHub
b449ee7
@aSemy aSemy marked this pull request as ready for review December 5, 2022 14:24
@aSemy aSemy marked this pull request as draft December 5, 2022 14:31
@aSemy aSemy marked this pull request as ready for review December 5, 2022 14:37
@aSemy
Copy link
Contributor Author

aSemy commented Dec 5, 2022 •
edited

hi @Raibaz, this is ready for review :)

UPDATE: hmmmm why are all the tests failing, they work on my machine. I'll take another look

UPDATE2: Okay it was a failing test, it should be fixed now

@oleksiyp
Copy link
Collaborator

oleksiyp commented Dec 6, 2022

Thanks a lot for this contribution and for taking care of mockk code!

@aSemy
Copy link
Contributor Author

aSemy commented Dec 6, 2022

@oleksiyp My pleasure! It's nice that MockK is accepting of PRs. While you're available, would you be able to help with #912 (comment)? @Raibaz needs to be able to set secrets :)

@Raibaz
Copy link
Collaborator

Raibaz commented Dec 6, 2022

Love this, thanks a lot!

@Raibaz Raibaz merged commit 3dba795 into mockk:master Dec 6, 2022
@aSemy aSemy deleted the chore/code_cleanup branch December 6, 2022 12:47
@stephanprantl stephanprantl mentioned this pull request Jan 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aSemy @oleksiyp @Raibaz