Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev-server-rollup] Failing test: node modules resolved outside root directory are rewritten with commonjs #1568

Open
web-padawan opened this issue Jul 26, 2021 · 3 comments · Fixed by #1569 or #1942
Labels

Comments

@web-padawan
Copy link
Contributor

There is one test failing after upgrading @rollup/plugin-node-resolve to 13.0.0 (#1433).

  1) @rollup/plugin-node-resolve
       node modules resolved outside root directory are rewritten with commonjs:
     Error: Timeout of 2000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/home/runner/work/web/web/packages/dev-server-rollup/test/node/plugins/node-resolve.test.ts)
      at listOnTimeout (internal/timers.js:554:17)
      at processTimers (internal/timers.js:497:7)

See https://github.com/modernweb-dev/web/pull/1567/checks?check_run_id=3159207368

Downgrading back to 11.0.0 makes this test pass. The reason is most likely this PR: rollup/plugins#799

@bennypowers
Copy link
Member

@web-padawan what was the root cause? reverting the plugin version is breaking esbuildPlugin({ ts: true }) for lit2

@bennypowers bennypowers reopened this Aug 18, 2021
@web-padawan
Copy link
Contributor Author

I will investigate.

@web-padawan
Copy link
Contributor Author

Reopening as the test was not fixed but skipped in #1942

@web-padawan web-padawan reopened this Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants