Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev-server-rollup] Update @rollup/plugin-node-resolve to v13 #1575

Closed
web-padawan opened this issue Jul 26, 2021 · 3 comments · Fixed by #1942
Closed

[dev-server-rollup] Update @rollup/plugin-node-resolve to v13 #1575

web-padawan opened this issue Jul 26, 2021 · 3 comments · Fixed by #1942

Comments

@web-padawan
Copy link
Contributor

The version has been downgraded by #1569 to make the failing test pass.
See #1568 for the example of a test failing with v13.

We need to investigate the failing test and then upgrade the plugin back. This should address these issues:

@abdonrd
Copy link
Contributor

abdonrd commented Jul 27, 2021

I see the CI also failing with @rollup/plugin-node-resolve v8: open-wc/open-wc#2182

@web-padawan
Copy link
Contributor Author

The failures in the open-wc seem to be unrelated and those PRs are outdated so I will close them.

Here is the change in v13 that apparently caused the test to break: rollup/plugins#799

@abdonrd
Copy link
Contributor

abdonrd commented Jul 27, 2021

Op! I confused the two repositories (web & open-wc)! 😅 haha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants