Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1443 up to 13 so web-test-runner happy in mjs configs #1444

Closed
wants to merge 1 commit into from

Conversation

btopro
Copy link

@btopro btopro commented May 10, 2021

copied from the issue in question for the full explanation

running node 14 and using rollup.config.mjs I was getting the following error: plugin_node_resolve_1.nodeResolve

In searching I was able to find that versions of https://www.npmjs.com/package/@rollup/plugin-node-resolve newer versions should resolve this config loading issue. In adding 13.0.0 to my package.json and running again it now correctly accepts the command. This seems an interrelated issues potentially as

https://github.com/modernweb-dev/web/blob/master/packages/dev-server-storybook/package.json#L62
dev-server-storybook is pointed to 11.x.x.

Making this 13 (assuming that still works) should resolve this issue for those of us starting to use .mjs based configuration routines.

@changeset-bot
Copy link

changeset-bot bot commented May 10, 2021

⚠️ No Changeset found

Latest commit: 6e139df

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@web-padawan
Copy link
Contributor

There is a breaking change that caused build to fail. See #1575 for more details. I'm closing this PR for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants