New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update puppeteer and puppeteer-core to 8.0.0 #1295
Conversation
🦋 Changeset detectedLatest commit: b23b0a0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Thanks for this! Puppeteer v7 ships it's own types now, so if we update we will need to remove the types package as well. |
@LarsDenBakker rebased and removed |
import * as puppeteerCore from 'puppeteer-core'; | ||
import { Browser, Page } from 'puppeteer-core'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These imports are added as a workaround for puppeteer/puppeteer#6904, let's wait for it to be fixed.
Thanks for this, sorry it took so long to merge |
What I did
puppeteer-core
andpuppeteer
versions to 8.0.0Closes #1254
Closes #1255
Closes #1260
Closes #1261
Closes #1322
Closes #1323