feat: async boundary option #1888
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refactor for easier management
…ors when replacing variables
…r using MFP (#1881) Co-authored-by: ScriptedAlchemy <zackary.l.jackson@gmail.com>
ScriptedAlchemy
changed the base branch from
main
to
feat_apply_bundler_runtime
ScriptedAlchemy
force-pushed
the
feat/async-boundary-option
branch
from
9f21375
to
77369ef
Compare
ScriptedAlchemy
force-pushed
the
feat/async-boundary-option
branch
from
77369ef
to
b5c4c3b
Compare
2heal1
reviewed
Jan 3, 2024
| @@ -553,6 +553,10 @@ export default { | |||
| runtime: { | |||
| $ref: '#/definitions/EntryRuntime', | |||
| }, | |||
| asyncBoundary: { | |||
There was a problem hiding this comment.
Should we update this option in "packages/enhanced/src/schemas/container/ModuleFederationPlugin.check.ts" ?
There was a problem hiding this comment.
ahh yes, i forgot to do the .ts file only did the schema file.
|
Stale pull request message |
2heal1
approved these changes
Mar 9, 2024
|
Stale pull request message |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
add
asyncBoundaryoption to federation plugin interfaceThis internally enables the automatic async boundary plugin, allowing it to be enabled without manually doing so.
Allows apps to be imported synchronously without getting eager error or call of undefined when not using a async import in the entrypoint.
Related Issue
N/A
Types of changes
Checklist