fix(enhanced): EagerModules to hoist internal runtime packages into runtime chunks #2238
+1,330
−366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ScriptedAlchemy
force-pushed
the
fix/chunk-runtime-integration
branch
from
3cb5622
to
cf8f2d3
Compare
ScriptedAlchemy
changed the title
added 9 commits
March 29, 2024 15:01
# Conflicts: # pnpm-lock.yaml
ScriptedAlchemy
force-pushed
the
fix/chunk-runtime-integration
branch
2 times, most recently
from
fc73de6
to
911d04d
Compare
ScriptedAlchemy
force-pushed
the
fix/chunk-runtime-integration
branch
from
911d04d
to
cc05e9a
Compare
ScriptedAlchemy
commented
Mar 30, 2024
| await __webpack_init_sharing__('default'); | ||
| expect(require('package')).toBe(42); | ||
| await new Promise((r) => { | ||
| setTimeout(r, 1000); |
There was a problem hiding this comment.
Because plugins start behind async boundary, test exists while require call is triggering
ScriptedAlchemy
force-pushed
the
fix/chunk-runtime-integration
branch
from
2a0c059
to
1698c72
Compare
Co-authored-by: ScriptedAlchemy <zackaryjackson@bytedance.com>
# Conflicts: # package.json
Co-authored-by: ScriptedAlchemy <zackaryjackson@bytedance.com>
✅ Deploy Preview for module-federation-new ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for module-federation-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Optimization allows only 1 runtime to be assigned to chunk
Fix multiple runtime id caused by conflicts in chunk integration.
Remove use of entrypoint prepending to inject runtime code
Implement EagerModule convention to hoist eager modules into runtime modules, without attaching them to share scope.
Related Issue
Types of changes
Checklist