Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: delete references to used shared to prevent memory leaks #2347

Merged
merged 3 commits into from May 14, 2024

Conversation

2heal1
Copy link
Member

@2heal1 2heal1 commented Apr 18, 2024

Description

delete references to used shared to prevent memory leaks

Related Issue

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the documentation.

Copy link

netlify bot commented Apr 18, 2024

Deploy Preview for module-federation-docs ready!

Name Link
🔨 Latest commit edbf6d8
🔍 Latest deploy log https://app.netlify.com/sites/module-federation-docs/deploys/6641f833c3fd6100086d02bf
😎 Deploy Preview https://deploy-preview-2347--module-federation-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@2heal1 2heal1 force-pushed the chore/prevent-memory-leak branch from 5590f8a to 4b4fd92 Compare May 13, 2024 08:42
Copy link

changeset-bot bot commented May 13, 2024

🦋 Changeset detected

Latest commit: edbf6d8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages
Name Type
@module-federation/enhanced Patch
@module-federation/managers Patch
@module-federation/runtime Patch
@module-federation/rspack Patch
@module-federation/nextjs-mf Patch
@module-federation/node Patch
3008-runtime-remote Patch
@module-federation/modernjs Patch
@module-federation/dts-plugin Patch
@module-federation/manifest Patch
@module-federation/devtools Patch
@module-federation/runtime-tools Patch
@module-federation/webpack-bundler-runtime Patch
node-dynamic-remote-new-version Patch
node-dynamic-remote Patch
@module-federation/sdk Patch
@module-federation/third-party-dts-extractor Patch
@module-federation/utilities Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@2heal1 2heal1 changed the title WIP: chore: delete references to used shared to prevent memory leaks chore: delete references to used shared to prevent memory leaks May 14, 2024
@2heal1 2heal1 merged commit 0113b81 into main May 14, 2024
10 checks passed
@2heal1 2heal1 deleted the chore/prevent-memory-leak branch May 14, 2024 02:09
@2heal1 2heal1 mentioned this pull request May 14, 2024
@ScriptedAlchemy
Copy link
Member

Amazing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants