-
-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: resolve dts-related files relative to remote manifest file #2477
Conversation
|
✅ Deploy Preview for module-federation-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Can you describe the use case or issue? |
@ScriptedAlchemy We have a MFE architecture. And we have the following requirements for our builds:
Up until dts, everything was automatically handled using relative URLs, so we could just deploy on any domain/path and everything would work. But with dts, this was not the case, since the dev machine has no idea which host to look for We're currently handling the situation through using |
Try public path auto. I just introduced its support back to MF manifests. Will auto mode work? |
@semekh does auto meet your needs? |
It looks like it does. Didn't have the chance to test it out yet though. |
Okay @semekh do you want to close/reopen if it doesnt do whats needed? |
Sure. Thanks. |
I'm sending this PR as a draft to see if you see this approach fit. I will add/fix tests if you are ok with the general idea.