Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "adjusted configuration to cover for compatibility on firefox and safari" #3118

Merged
merged 1 commit into from
Jul 13, 2023

Conversation

wibed
Copy link
Contributor

@wibed wibed commented Jul 13, 2023

Reverts #3107

the changes make it render on firefox/safari. but client side javascript is still broken.
#3117

@vercel
Copy link

vercel bot commented Jul 13, 2023

@wibed is attempting to deploy a commit to the Module Federation Team on Vercel.

A member of the Team first needs to authorize it.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions
Copy link

Workflow status is failure ❌
Unfortunately test report wasn't generated, it can be if no workspaces changed. Please check the workflow run below.
Link to GitHub workflow: Github Workflow Link

@github-actions github-actions bot added the workflow-failure Workflow is failed label Jul 13, 2023
@ScriptedAlchemy ScriptedAlchemy merged commit 57772c0 into module-federation:master Jul 13, 2023
8 of 15 checks passed
@wibed wibed deleted the revert-3107-master branch July 15, 2023 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
workflow-failure Workflow is failed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants