type errors(both) and streaming issue(only iOS) after in-app browse #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we need to check double variables' response type for preventing type errors. I didn't check 'popularity' or others. I checked only 'vote_average'. If there is no user vote on a movie, Api will response int(0) value. Example movie: we can try to see details movie-id "573259". We will see "type 'int' is not a subtype of type 'double'" error...
for iOS; After in-app browsing(like navigate to teaser url) and back to app, Streamer calls chipLayout again as all others. So genresList increases (^2) on every same navigation scenario. required to be checked(first loop)
DrAchernar
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.