Skip to content

Commit

Permalink
Fixes & Updates for latest dependencies (#38)
Browse files Browse the repository at this point in the history
### Dependency updates:
- Fixes for the latest version of async which introduced a breaking change --> caolan/async#1641
- Removed ignore dependency list from .ncurc.json as all issues have been resolved
- Following dependencies were updated:
 async          2.6.2  →   3.1.0
 node-rdkafka   2.6.1  →   2.7.1
 raw-body       2.4.0  →   2.4.1
 sinon          7.2.4  →   7.4.2
 tap-xunit      2.3.0  →   2.4.1
 tape          4.10.1  →  4.11.0

### Maintenance updates:
- Replaced central-services-shared dep with central-service-logger
- Migrated from istanbul to nyc
- Moved unit tests to a test/unit folder to be consistent with other repos
- Added editorconfig, eslintignore, & eslintrc for consistency with other repos
  • Loading branch information
mdebarros committed Sep 16, 2019
1 parent eca5db8 commit d8341e5
Show file tree
Hide file tree
Showing 24 changed files with 1,980 additions and 3,320 deletions.
4 changes: 2 additions & 2 deletions .circleci/config.yml
Expand Up @@ -132,7 +132,7 @@ jobs:
if [ "${CIRCLE_BRANCH}" == "master" ];
then
echo "Sending lcov.info to SonarQube..."
aws s3 cp coverage/lcov.info $AWS_S3_DIR_SONARQUBE/central-services-stream/lcov.info
aws s3 cp coverage/lcov.info $AWS_S3_DIR_SONARQUBE/${CIRCLE_PROJECT_REPONAME}/lcov.info
else
echo "Not a release (env CIRCLE_BRANCH != 'master'), skipping sending lcov.info to SonarQube."
fi
Expand All @@ -152,7 +152,7 @@ jobs:
command: mkdir -p ./audit/results
- run:
name: Check for new npm vulnerabilities
command: npm run audit:check --silent -- --json > ./audit/results/auditResults.json
command: npm run audit:check --silent -- --json > ./audit/results/auditResults.json
- store_artifacts:
path: ./audit/results
prefix: audit
Expand Down
18 changes: 18 additions & 0 deletions .editorconfig
@@ -0,0 +1,18 @@
root = true

[*]
end_of_line = lf
insert_final_newline = true
trim_trailing_whitespace = true
charset = utf-8

[*.js]
indent_style = space
indent_size = 2

[{package.json,*.yml,*.cjson}]
indent_style = space
indent_size = 2

[*.md]
trim_trailing_whitespace = false
2 changes: 2 additions & 0 deletions .eslintignore
@@ -0,0 +1,2 @@
coverage
templates
31 changes: 31 additions & 0 deletions .eslintrc
@@ -0,0 +1,31 @@
{
"parserOptions": {
"ecmaVersion": 9
},
"rules": {
"no-console": [
"off"
],
"indent": [
2,
2
],
"quotes": [
2,
"single"
],
"linebreak-style": [
2,
"unix"
],
"semi": [
2,
"never"
]
},
"env": {
"es6": true,
"node": true
},
"extends": "eslint:recommended"
}
17 changes: 0 additions & 17 deletions .istanbul.yml

This file was deleted.

9 changes: 1 addition & 8 deletions .ncurc.json
@@ -1,11 +1,4 @@
{
"reject": [
"async",
"sinon",
"events",
"node-rdkafka",
"raw-body",
"tap-xunit",
"tape"
]
}
}
2 changes: 1 addition & 1 deletion .nvmrc
@@ -1 +1 @@
8.9.4
10.15.1
19 changes: 19 additions & 0 deletions .nycrc.yml
@@ -0,0 +1,19 @@
temp-directory: "./.nyc_output"
check-coverage: true
per-file: true
lines: 90
statements: 90
functions: 90
branches: 90
all: true
include: [
"src/**/*.js"
]
reporter: [
"lcov",
"text-summary"
]
exclude: [
"**/node_modules/**",
"**/src/kafka/examples/**"
]

0 comments on commit d8341e5

Please sign in to comment.