Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Treat covariant return type as an error #87

Closed
wants to merge 1 commit into from
Closed

Treat covariant return type as an error #87

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion animal-sniffer/src/main/java/org/codehaus/mojo/animal_sniffer/SignatureChecker.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -620,10 +620,11 @@ private boolean find( Clazz c , String sig , boolean baseFind )
+ ": Covariant return type change detected: "
+ toSourceForm( c.getName(), oldSignature ) + " has been changed to "
+ toSourceForm( c.getName(), sig ) );
return true;
return false;
}
}
}
return true;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should still return false

you can remove both return statements and let it fall through to return false (while keeping the logging)

}
return false;
}
Expand Down