Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a property name to the "sources" parameter for CLI usage #157

Merged
merged 1 commit into from
May 6, 2023

Conversation

gjd6640
Copy link
Contributor

@gjd6640 gjd6640 commented Nov 7, 2022

See issue #156.

This command demonstrate this change in action:

mvn dependency:tree -DoutputFile=target/sonar-scan-reports/maven-dependency-tree.txt org.codehaus.mojo:build-helper-maven-plugin:3.4.0-SNAPSHOT:add-source -Dsources="./target/sonar-scan-reports/,./target/someOtherDir/"

As described in the issue the idea here is to enable the user to generate files for each of the project's Maven modules and teach Maven where to find those files. This way when a plugin that runs later (ie: Sonarqube's scanner) executes Maven will provide it with the locations of these additional source files.

@gjd6640
Copy link
Contributor Author

gjd6640 commented Dec 14, 2022

@slachiewicz @stefanseifert Would one of you mind reviewing this pull request and associated issue and merge it if it looks like a good change?

I apologize in advance if there's a contributor's guide that I'm not following. I looked and didn't see any instructions for getting a proposed change vetted and merged.

Thank you and have a great day!

@gjd6640
Copy link
Contributor Author

gjd6640 commented Jan 20, 2023

@dantran @khmarbaise Would one of you mind reviewing this pull request and associated issue and then merge it if it looks good?

Thanks in advance!

@gjd6640
Copy link
Contributor Author

gjd6640 commented Feb 28, 2023

@slachiewicz Hello. Would you mind reviewing and merging this one? It is a pretty simple change. Thanks in advance!

@gjd6640
Copy link
Contributor Author

gjd6640 commented May 3, 2023

@slawekjaranowski Would you mind reviewing and merging this one? It is a pretty simple change. Thanks in advance!

Alternatively, if you're short on active participants that are able to review issues and pull requests you could add me as a maintainer.

@slawekjaranowski
Copy link
Member

New sources should be added by configuration in pom, it can depends on previous executed goal ...
I see you want to execute additional goals by provided them by cli

We have also goals like add-test-source, add-resource, add-test-resource.... maybe those should also have a property ... but ok can be next time

@gjd6640
Copy link
Contributor Author

gjd6640 commented May 6, 2023

@slawekjaranowski Thank you for looking at this one. I agree that we may later want to add properties for other goals and that there's no need to include those changes here. Is there anything that you need from me at this time?

@slawekjaranowski slawekjaranowski merged commit 0bdc352 into mojohaus:master May 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request: Capability to use goal "add-source" from the command line
2 participants