#36 #14 #32 Cobertura Logback redesign and partial Maven 3.x updates #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using maven-site-plugin to generate cobertura was causing all kinds of weird dependency issues so we need alternative means of generating the cobertura.xml report. The report is generated based on previously generated cobertura.ser file that is created by calling cobertura:instrument first.
These changes require corresponding changes in coberura. - Changed Cobertura logging configuration file to logback and included logback SLF4J binding for runtime scope. The use of logback was not really necessary and Log4J would of worked to as long as binding library is provided. I chose logback to be consitent with how Cobertura stand-alone tool works. - Updated the necessary code to use the new configuration file. - Updated maven requirements to 3.3.1 - Partial update of maven API versions to 3.x (mojohaus#32 Update to maven 3 apis ) - Cobertura-plugin 2.7 modifies the build's log4j configuration mojohaus#36 mojohaus#32 mojohaus#14
… build." This reverts commit 23a6fca.
msiemczyk
changed the title
More changes related to maven API versions to 3.x that fix unit and integration tests. The actual production code still needs to be adapted to 3.x API. mojohaus#32 Update to maven 3 apis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These commits include Cobertura logback redesign and partial maven 3.x API updates. Also updated Java version to 1.7 since that new Cobertura version requires 1.7.
These changes are dependant on releasing new version of Cobertura, which might not happen anytime soon since the owner seems to be not responding.
Please ignore generate-report file, I need to create a separate pull request for that.