Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get some feedback from Maven core #402

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

cstamas
Copy link

@cstamas cstamas commented Dec 21, 2023

Detach prerequisite and compile dependencies.

For me, now build speaks. In src/main/java:

[WARNING] /home/cstamas/Worx/mojohaus/exec-maven-plugin/src/main/java/org/codehaus/mojo/exec/AbstractExecMojo.java:[141,37] getCompileArtifacts() in org.apache.maven.project.MavenProject has been deprecated
[WARNING] /home/cstamas/Worx/mojohaus/exec-maven-plugin/src/main/java/org/codehaus/mojo/exec/AbstractExecMojo.java:[146,37] getTestArtifacts() in org.apache.maven.project.MavenProject has been deprecated
[WARNING] /home/cstamas/Worx/mojohaus/exec-maven-plugin/src/main/java/org/codehaus/mojo/exec/AbstractExecMojo.java:[152,37] getRuntimeArtifacts() in org.apache.maven.project.MavenProject has been deprecated
[WARNING] /home/cstamas/Worx/mojohaus/exec-maven-plugin/src/main/java/org/codehaus/mojo/exec/AbstractExecMojo.java:[157,37] getSystemArtifacts() in org.apache.maven.project.MavenProject has been deprecated
[WARNING] /home/cstamas/Worx/mojohaus/exec-maven-plugin/src/main/java/org/codehaus/mojo/exec/ExecMojo.java:[945,90] ROLE in org.apache.maven.toolchain.ToolchainManager has been deprecated
[WARNING] /home/cstamas/Worx/mojohaus/exec-maven-plugin/src/main/java/org/codehaus/mojo/exec/ExecMojo.java:[945,51] getContainer() in org.apache.maven.execution.MavenSession has been deprecated
[WARNING] /home/cstamas/Worx/mojohaus/exec-maven-plugin/src/main/java/org/codehaus/mojo/exec/ExecJavaMojo.java:[472,31] stop() in java.lang.Thread has been deprecated

And in src/test/java:

[WARNING] /home/cstamas/Worx/mojohaus/exec-maven-plugin/src/test/java/org/codehaus/mojo/exec/ExecJavaMojoTest.java:[336,27] initMocks(java.lang.Object) in org.mockito.MockitoAnnotations has been deprecated

Detach prerequisite and compile dependencies.
@cstamas
Copy link
Author

cstamas commented Dec 21, 2023

Related to #401

@cstamas
Copy link
Author

cstamas commented Dec 21, 2023

All the refd MavenProject methods are below this (also a 9 year old banner):
https://github.com/apache/maven/blob/maven-3.9.x/maven-core/src/main/java/org/apache/maven/project/MavenProject.java#L1246-L1256

@slawekjaranowski
Copy link
Member

All the refd MavenProject methods are below this (also a 9 year old banner):

The problem is that we don't have a documents what is replacement in Maven 3 for many deprecated methods.

The problem is that we don't have a documents what is replacement for many deprecated methods in Maven 3.
In Maven 4 is more clear an API.

Comment on lines +125 to +126
<mavenMinVersion>3.6.3</mavenMinVersion>
<mavenVersion>3.9.6</mavenVersion>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if it good idea.
After it we will can use newer methods from API ... and we will have an exception in runtime on older Maven.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that this is wrong, but if we will run tests with 3.6.3 we should sooner or later catch it

@slawekjaranowski
Copy link
Member

please look at #414

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants