Do not get UPPERCASE env vars #427
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@slawekjaranowski thanks I made that change |
| // https://github.com/mojohaus/exec-maven-plugin/issues/328 | ||
| // It is not enough to avoid duplicates; we must preserve the case found in the "natural" environment. | ||
| // https://developercommunity.visualstudio.com/t/Build-Error:-MSB6001-in-Maven-Build/10527486?sort=newest | ||
| Map<String, String> enviro = System.getenv(); |
There was a problem hiding this comment.
Should be a copy here, getenv can return unmodifiable map
|
please rebuild project with JDK 11+ to see errors from spotless |
|
Please also look at: we can have a duplicate keys like |
|
Thera is also User can provide env values with different format |
|
@wheezil How's work going? |
|
Hi I am on vacation for a while, will get back to this in about a month
…On Tue, May 21, 2024, 21:17 Slawomir Jaranowski ***@***.***> wrote:
@wheezil <https://github.com/wheezil> How's work going?
—
Reply to this email directly, view it on GitHub
<#427 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADKXHCJKTCLGWU4AR6VBRJTZDOMVTAVCNFSM6AAAAABHRIE3RGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMRTGI4DKNRVGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We hit this issue when we updated MSBuild to latest VS2022.
The problem original appears to be simply that maven-exec-plugin was adding both
EnvironmentVariableand its twin that differs only by case
ENVIRONMENTVARIABLEwhich was indeed a problem. However, simply removing the duplicates didn't work, because MSBuild is "special". Apparently, if you have an env var like
OneDriveand maven-exec-plugin turns that into ONEDRIVE for the launched process environment block, MSBuild somehow finds the original env var definitions (in the registry?) and attempts to add them. It doesn't detect the duplicate that differs only in case until it is too late and it errors out as described in this MS bug reportThe answer is trivially simple -- don't UPPERCASE the env vars