Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#499 - Let update-parent support -DallowMajorUpdates and alike #500

Conversation

askoog
Copy link

@askoog askoog commented Sep 28, 2021

Implement support for allowMajorUpdates, allowMinorUpdates and allowIncrementalUpdates in update-parent

Copy link
Contributor

@stefanseifert stefanseifert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the PR - can you come up with integration tests as well for the new functionality?
please also rebase/merge with current develop branch to resolve the conflicts.

@slawekjaranowski
Copy link
Member

@askoog thanks for refresh PR.

as @stefanseifert said, IT test will be appreciated
We should be sure with next changes that feature still works.

@slawekjaranowski slawekjaranowski linked an issue Aug 26, 2022 that may be closed by this pull request
@jarmoniuk
Copy link
Contributor

@askoog Hi there, do you still want to finish this PR? If you want, I could take it over and finish what's left to do. Please reach out.

@askoog
Copy link
Author

askoog commented Sep 29, 2022

@ajarmoniuk Please feel free if you want to continue with this PR. I tried to fix errors and also added some tests, but when I rebased on master I see that you have made quite a few changes in the latest version and some of the methods I used have been removed :/
Probably you have more insight in how to implement this feature.

@jarmoniuk
Copy link
Contributor

Actually we'd like to give this allow...Updates system a slight overhaul, at least in its inner workings, since those options are not mutually independent and it's much better to represent them as e.g. an enum, at least internally. And, obviously, furnishing this mojo with this feature is coming :)

@askoog
Copy link
Author

askoog commented Oct 2, 2022

I see. Yes that sounds like a good idea. I guess it will be easier to implement the functionality in other mojos as well then.

The allowXxxUpdates is a great addition to this plugin and we use it very frequently. We have several hundred maven projects that we continuously keep up to date using this plugin and internally we have different major versions for our development platform projects based on java version, spring version etc. Upgrading to a different major is often a bigger task than just upgrading patch versions and therefore it is great to be able to perform automatic updates for just pathches/minors and not majors.

Anyhow, I will leave this PR to you, if you want to close it, go ahead. Feel free to reach out if there is anything I can help with

@jarmoniuk
Copy link
Contributor

jarmoniuk commented Oct 3, 2022

Working on it. I'll wait till #733 is merged since I'd like to use the BoundArtifactVersions there, just like in UpdateLatestReleasesMojo.

Incrementing a segment to obtain the upper bound brings caveats with itself -- we may indadvertedly update to a beta or a snapshot version from the next major release because these lie before the .0 versions. Which my PR #733 fixes.

@slawekjaranowski
Copy link
Member

@askoog thanks for your effort , I assume that now it is resolved by #737

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update-parent does not respect -DallowMajorUpdates
4 participants