Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update packages sizes #312

Closed
wants to merge 1 commit into from
Closed

update packages sizes #312

wants to merge 1 commit into from

Conversation

felixcatto
Copy link

2023-05-20_08-32_1

2023-05-20_08-32

I think minified versions is better for size comparison. Because wouter becomes only 2x smaller after gzip, but react-router - 3x smaller.

And i think minified size matters even more than gzipped, because scripts loads once, then cached. But they parsed and
evaluated on every load. Therefore 65 Kb slow down script execution much more than 4.4 Kb

@codecov
Copy link

codecov bot commented May 20, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (ecd0c45) 100.00% compared to head (9f77ca3) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #312   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines          224       224           
  Branches        58        58           
=========================================
  Hits           224       224           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@molefrog
Copy link
Owner

That's fair enough. I would maybe put it this way though: "Only 1.5KB gzipped (4.5KB minified)".
For comparison, Preact advertises itself as "3KB alternative for React", while their minified version is over 10KB.

We could also solve this by having a more detailed table comparing RR and wouter in all possible forms: original, minified, minified + gzipped.

image

@felixcatto
Copy link
Author

I just wanted to update info about sizes, because the difference between React-router now is bigger. Feel free to discard this pull request and write whatever you think is more appropriate 😉

@molefrog
Copy link
Owner

I just wanted to update info about sizes, because the difference between React-router now is bigger. Feel free to discard this pull request and write whatever you think is more appropriate 😉

Gotcha! Thank you for suggesting this, you have a really good point here.

@felixcatto felixcatto closed this Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants