Deduplicate code #314
Merged
Deduplicate code #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #314 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 5 6 +1
Lines 224 228 +4
Branches 58 56 -2
=========================================
+ Hits 224 228 +4
☔ View full report in Codecov by Sentry. |
molefrog
reviewed
May 22, 2023
| @@ -18,7 +20,7 @@ const ESM_SOURCES = [ | |||
|
|
|||
| const OUTPUT_DIR = "cjs"; | |||
|
|
|||
| export default [ | |||
| export default defineConfig([ | |||
There was a problem hiding this comment.
what's the advantage of using defineConfig here?
There was a problem hiding this comment.
defineConfig provides type definitions:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tweak rollup config to deduplicate path helpers in code base.