Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3: Migrate packages to monorepo #318

Merged
merged 11 commits into from
May 26, 2023
Merged

v3: Migrate packages to monorepo #318

merged 11 commits into from
May 26, 2023

Conversation

jeetiss
Copy link
Collaborator

@jeetiss jeetiss commented May 26, 2023

  • migrate wouter and wouter-preact to monorepo
  • export only esm, drop cjs exports
  • test with jest (but coverage is broken)

@codecov
Copy link

codecov bot commented May 26, 2023

Codecov Report

Patch coverage has no change and project coverage change: -100.00 ⚠️

Comparison is base (30362e2) 100.00% compared to head (e5544ca) 0.00%.

❗ Current head e5544ca differs from pull request most recent head 7e455a9. Consider uploading reports for the commit 7e455a9 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##                v3    #318        +/-   ##
============================================
- Coverage   100.00%   0.00%   -100.00%     
============================================
  Files            6       1         -5     
  Lines          228       6       -222     
  Branches        56       2        -54     
============================================
- Hits           228       0       -228     
- Misses           0       4         +4     
- Partials         0       2         +2     

see 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

package.json Outdated Show resolved Hide resolved
"./react-deps.js"
]
"path": "packages/wouter/dist/index.js",
"limit": "2000 B",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Limits are increased, may I ask why?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to make size-limit happy)

I included react-deps.js to bundle-size test and it not only increases the size but causes some deoptimizations i guess:

this code can be deleted and included in final size tests

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it should be

import { 
   useEffect, 
   useLayoutEffect, 
   useRef, 
   useInsertionEffect as useBuiltinInsertionEffect, 
 } from 'react'; 

to fix all three-shaky stuff

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but it can break some old react versions that doesn't provide useInsertionEffect

Copy link
Owner

@molefrog molefrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the root, there is a file paths.js I guess we don't need it anymore.

Copy link
Owner

@molefrog molefrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the root, there is a file paths.js I guess we don't need it anymore.

@molefrog molefrog changed the base branch from main to v3 May 26, 2023 11:10
@molefrog molefrog changed the title Migrate packages to monorepo v3: Migrate packages to monorepo May 26, 2023
@molefrog molefrog merged commit 4791554 into molefrog:v3 May 26, 2023
2 checks passed
@jeetiss jeetiss deleted the monorepo-pr branch November 22, 2023 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants