-
-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base vitest setup #320
base vitest setup #320
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Could you pls check why route parameters are not inferred?
it("supports history.back() navigation", () => { | ||
jest.useFakeTimers(); | ||
// Vitest doesn't support Jest's legacy timers. | ||
it.skip("supports history.back() navigation", () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don’t even remember why I had to use fake timers here. Does the test pass when you remove these calls?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I replaced FakeTimers
with waitFor
util from testing-library
and test works
Nice, thank you! |
vitest
typescript
add a lot of// @ts-expect-error
comments