Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix colon in front of dynamic segments #404

Merged
merged 1 commit into from
Jan 10, 2024
Merged

Conversation

pReya
Copy link

@pReya pReya commented Jan 10, 2024

The regex quantifiers in the documentation for dynamic segments were missing a colon, which is probably unwanted in my opinion.

Copy link

stackblitz bot commented Jan 10, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

codesandbox bot commented Jan 10, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@pReya pReya changed the title fix: colon in front of dynamic segments docs: fix colon in front of dynamic segments Jan 10, 2024
Copy link

codecov bot commented Jan 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (494bb7c) 100.00% compared to head (1a5a826) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #404   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines          226       226           
  Branches        56        56           
=========================================
  Hits           226       226           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@molefrog molefrog merged commit 5c232aa into molefrog:main Jan 10, 2024
4 checks passed
@pReya pReya deleted the patch-1 branch January 10, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants