Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Routes with no path fall back to "*" #411

Merged
merged 1 commit into from
Feb 4, 2024
Merged

Conversation

molefrog
Copy link
Owner

@molefrog molefrog commented Feb 2, 2024

A small sugar to save up some space, make the code more elegant and enable some nice DX tricks. This is the last commit before the V3 release!

@molefrog molefrog requested a review from jeetiss February 2, 2024 10:07
Copy link

codesandbox bot commented Feb 2, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link

stackblitz bot commented Feb 2, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

github-actions bot commented Feb 2, 2024

size-limit report 📦

Path Size
packages/wouter/esm/index.js 2.06 KB (-0.29% 🔽)
packages/wouter/esm/use-browser-location.js 658 B (0%)
packages/wouter/esm/memory-location.js 834 B (0%)
packages/wouter/esm/use-hash-location.js 737 B (0%)
packages/wouter-preact/esm/index.js 1.94 KB (-0.51% 🔽)
packages/wouter-preact/esm/use-browser-location.js 552 B (0%)
packages/wouter-preact/esm/use-hash-location.js 607 B (0%)
packages/wouter-preact/esm/memory-location.js 702 B (0%)

Copy link

codecov bot commented Feb 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (eb58a3d) 100.00% compared to head (67ca9cf) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##                v3      #411   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines            1         1           
=========================================
  Hits             1         1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@jeetiss jeetiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💅

@molefrog molefrog merged commit a83bab7 into v3 Feb 4, 2024
4 checks passed
@molefrog molefrog deleted the chore/empty-route-wild branch February 4, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants