Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Extract ssrSearch from ssrPath when possible #420

Merged
merged 2 commits into from
Mar 3, 2024

Conversation

molefrog
Copy link
Owner

When ssrPath contains a ? character, we can extract ssrSearch from it. Example:

// `ssrSearch` is "order=asc" 
<Router ssrPath="/blog?order=asc" />

Copy link

stackblitz bot commented Feb 26, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

codesandbox bot commented Feb 26, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link

github-actions bot commented Feb 26, 2024

size-limit report 📦

Path Size
packages/wouter/esm/index.js 2.09 KB (+1.86% 🔺)
packages/wouter/esm/use-browser-location.js 658 B (0%)
packages/wouter/esm/memory-location.js 834 B (0%)
packages/wouter/esm/use-hash-location.js 737 B (0%)
packages/wouter-preact/esm/index.js 1.97 KB (+1.98% 🔺)
packages/wouter-preact/esm/use-browser-location.js 552 B (0%)
packages/wouter-preact/esm/use-hash-location.js 607 B (0%)
packages/wouter-preact/esm/memory-location.js 702 B (0%)

Copy link

codecov bot commented Feb 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (c5efa2e) to head (78ca454).
Report is 1 commits behind head on v3.

Additional details and impacted files
@@            Coverage Diff            @@
##                v3      #420   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines            1         1           
=========================================
  Hits             1         1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@molefrog molefrog merged commit 3fb98e5 into v3 Mar 3, 2024
4 checks passed
@molefrog molefrog deleted the feat/infer-ssr-search branch March 3, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant