Fix active link highlighting when using custom href formatting #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v3 #444 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 1 1
=========================================
Hits 1 1 ☔ View full report in Codecov by Sentry. |
molefrog
reviewed
May 10, 2024
packages/wouter/src/index.js
Outdated
| @@ -236,7 +236,7 @@ export const Link = forwardRef((props, ref) => { | |||
| onClick, | |||
| href, | |||
| // `className` can be a function to apply the class if this link is active | |||
| className: cls?.call ? cls(path === href) : cls, | |||
| className: cls?.call ? cls(currentPath === (targetPath)) : cls, | |||
There was a problem hiding this comment.
Everything looks good! One small question: do we need extra braces around targetPath here?
There was a problem hiding this comment.
Definitely not :) No idea what I was thinking. Thanks for the catch — fix pushed.
molefrog
approved these changes
May 10, 2024
Previously when we formatted the `href` attribute (for example, to prefix a `#` when using useHashLocation) this would make it not match the current path, which would not have the hash prefix. This patch preserves the target (href, or to) of the Link component and then compares this value to the active path. This should then match. I have also altered some variable names to improve clarity given we now have four different various 'paths' in this component. Fixes molefrog#417
|
Released in v3.1.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #417 (comment) for details on the problem.
Previously when we formatted the
hrefattribute (for example, to prefix a#when using useHashLocation) this would make it not match the current path, which would not have the hash prefix.This patch preserves the target (href, or to) of the Link component and then compares this value to the active path. This should then match.
I have also altered some variable names to improve clarity given we now have four different various 'paths' in this component.
I have tested this: in this repo, in my previous reproduction, and in the application I am building — so I feel reasonably confident it fixes my issue at least :)
Fixes #417