Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(settings): Let email input field scale with the content #2635

Closed
wants to merge 2 commits into from

Conversation

MaxPostema
Copy link
Contributor

partial fix for: #549
It will still need the discussion about using emails. For now we still have non email keys like anonymous and admin to deal with so i wont be changing the input type.

@sonarcloud
Copy link

sonarcloud bot commented Aug 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@mswertz
Copy link
Member

mswertz commented Aug 15, 2023

It will still need the discussion about using emails. For now we still have non email keys like anonymous and admin to deal with so i wont be changing the input type.

I propose the final change should have:

  • add role select input for 'user' (authenticated users) and 'anonymous' (non-signed in users) => default to 'null'
  • replace with email validated input for any other user

Copy link
Member

@mswertz mswertz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is okay, but you might want to take the step to complete this by adding email validation AND adding seperate role select inputs for the 'anonymous' and 'user' special user groups.

P.S. please also use semantic commit messages. I have now change label to fit

@mswertz mswertz changed the title Let email input field scale with the content fix(settings): Let email input field scale with the content Aug 15, 2023
@MaxPostema
Copy link
Contributor Author

Closed in favor of #2684

@MaxPostema MaxPostema closed this Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants