Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Some data items under section 'Access conditions' in Cohort vie… #3761

Conversation

connoratrug
Copy link
Contributor

…w are not shown or need to be renamed

Closes #3600

What are the main changes you did:

  • explain what you changed and essential considerations.

how to test:

  • explain here what to do to test this (or point to unit tests)

todo:

  • updated docs in case of new feature
  • added/updated tests
  • added/updated testplan to include a test for this fix, including ref to bug using # notation

Copy link
Member

@mswertz mswertz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good. @BrendaHijmans please approve after functional test

mswertz and others added 3 commits May 22, 2024 11:00
…conditions-in-cohort-view-are-not-shown-or-need-to-be-renamed
…conditions-in-cohort-view-are-not-shown-or-need-to-be-renamed
Copy link

sonarcloud bot commented May 22, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@connoratrug connoratrug merged commit 09a31a0 into master May 22, 2024
5 of 6 checks passed
@connoratrug connoratrug deleted the 3600-some-data-items-under-section-access-conditions-in-cohort-view-are-not-shown-or-need-to-be-renamed branch May 22, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some data items under section 'Access conditions' in Cohort view are not shown or need to be renamed
2 participants