chore: update critical packages, fix tests, update error check #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denisand
commented
Jan 6, 2023
| @@ -7,7 +7,7 @@ export default async function getPaymentDetailsById(paymentId: string, mollieCli | |||
| return payment; | |||
| } catch (error: any) { | |||
| Logger.debug('Error in getPaymentDetailsById'); | |||
| if (error.status === 404) { | |||
| if (error.statusCode === 404) { | |||
There was a problem hiding this comment.
Since 2.6.0 mollie-api-node returns statusCode instead of status, check mollie/mollie-api-node@v3.5.1...v3.6.0 and find src/errors/ApiError.ts
| @@ -7,7 +7,7 @@ export default async function getOrderDetailsById(orderId: string, mollieClient: | |||
| return order; | |||
| } catch (error: any) { | |||
| Logger.debug('Error in getOrderDetailsById'); | |||
| if (error.status === 404) { | |||
| if (error.statusCode === 404) { | |||
There was a problem hiding this comment.
Since 2.6.0 mollie-api-node returns statusCode instead of status, check mollie/mollie-api-node@v3.5.1...v3.6.0 and find src/errors/ApiError.ts
| @@ -40,8 +39,8 @@ describe('handleRequest', () => { | |||
| Logger.error = mockLogError; | |||
| Logger.debug = mockLogDebug; | |||
|
|
|||
| mocked(handleOrderWebhook).mockResolvedValue(mockCTPayment); | |||
| mocked(handlePaymentWebhook).mockResolvedValue(mockCTPayment); | |||
| jest.mocked(handleOrderWebhook).mockResolvedValue(mockCTPayment); | |||
There was a problem hiding this comment.
ts-jest/utils and mocked are removed from v28.0.0 on (kulshekhar/ts-jest#3334), reworked as suggested on their repo
This was referenced Jan 6, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
mockedin tests withjest.mockedas result of removedts-jest/utilsfrom v28.0.0 on (feat(core): removets-jest/utilssub path export kulshekhar/ts-jest#3334)Type of change
Testing
Checklist: