Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export VERSION information #794

Merged
merged 4 commits into from
Nov 9, 2020
Merged

Export VERSION information #794

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
972e157
Export VERSION information
pgcalixto Oct 3, 2020
3325dff
Revert "Export VERSION information"
pgcalixto Oct 8, 2020
2a14727
Export hardcoded VERSION variable
pgcalixto Oct 8, 2020
367d95f
Move version validation to dedicated script
pgcalixto Oct 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

21 changes: 16 additions & 5 deletions scripts/tag
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,21 @@
#!/usr/bin/env bash

abort() {
echo "ERROR: $1"
exit 1
}

PACKAGE_VERSION=$(node -p "require('./package.json').version")
PACKAGE_LOCK_VERSION=$(node -p "require('./package-lock.json').version")
EXPORTED_VERSION=$(grep -oP "(?<=const VERSION = \").*(?=\";)" ./src/luxon.js)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure grep will work on Windows for instance, but that may not be an issue.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought about it too, but all these scripts have #!/usr/bin/env bash in the beginning, reinforcing the idea to run them on Bash, which afaik always has grep, even in Bash for Windows.

(also, the syntax of the scripts have other details that would only allow them to be run on Bash)


if [ $(git tag -l "$PACKAGE_VERSION") ]; then
echo "tag already exists"
else
git tag $PACKAGE_VERSION
git push origin master $PACKAGE_VERSION
if [ $PACKAGE_VERSION != $PACKAGE_LOCK_VERSION ]; then
abort "package-lock.json's version differs from package.json's"
elif [ $PACKAGE_VERSION != $EXPORTED_VERSION ]; then
abort "exported version differs from package.json's"
elif [ $(git tag -l "$PACKAGE_VERSION") ]; then
abort "tag already exists"
fi

git tag $PACKAGE_VERSION
git push origin master $PACKAGE_VERSION
3 changes: 3 additions & 0 deletions src/luxon.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,10 @@ import InvalidZone from "./zones/invalidZone.js";
import LocalZone from "./zones/localZone.js";
import Settings from "./settings.js";

const VERSION = "1.25.0";

export {
VERSION,
DateTime,
Duration,
Interval,
Expand Down