Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bypassing chrome intl timezone bug fix #517 #529

Conversation

bolasblack
Copy link

No description provided.

@jsf-clabot
Copy link

jsf-clabot commented Sep 20, 2017

CLA assistant check
All committers have signed the CLA.

@bolasblack bolasblack force-pushed the bypassing-chrome-intl-timezone-bug branch from 47da9fb to ff60526 Compare September 20, 2017 12:02
@mattjohnsonpint
Copy link
Contributor

Thanks, but I don't think this much examination is required. The reported bad results have all been three-character abbreviations, from what I have been able to ascertain. Closing in favor of #553

@bolasblack
Copy link
Author

Hi @mj1856 , I think you misunderstood me, I was trying to fix the issue #517 , not #423

In some region (for example Asia/Shanghai), when I executing Intl.DateTimeFormat().resolvedOptions().timeZone in chrome 61.0.3163.100, I will get America/Chicago, not Asia/Shanghai

I think check Intl.DateTimeFormat().resolvedOptions().timeZone.length > 3 can not fix this issue.

@mattjohnsonpint
Copy link
Contributor

Oh, I see. Let me take another look at this. Thanks.

@gregclarke
Copy link

In addition to the above, in some circumstances the resolved timezone is incorrect. On arch linux firefox version 56.0.2 Intl.DateTimeFormat().resolvedOptions().timeZone returns Etc/GMT-10 which is an hour out due to daylight savings (correct timezone is Australia/Sydney). The length check doesn't work in this case either. I've temporarily solved by using
var tmpName = intlName.split('/')[0]; if (intlName && tmpName.length > 3)

@iffy
Copy link

iffy commented Apr 26, 2018

@mj1856 Can you please reopen this/reconsider this as a way to fix 517?

@morajabi
Copy link

morajabi commented Jun 5, 2018

@mj1856 I have this problem :( How can we fix it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants