solved issue-#4783 #4786
Closed
solved issue-#4783 #4786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Travis failed on locale/ka.js - which was untouched by this PR. I notice some others PR had the same problem (#4762) Also, there seems to be a problem with job 4282.6 related to installing dependencies. Thanks |
| @@ -504,6 +504,18 @@ test('when in strict mode with inexact parsing, treat periods in min-weekdays li | |||
| assert.equal(moment('thurs', 'dd', true).format('dddd'), 'Thursday'); | |||
| }); | |||
|
|
|||
| test('when weekdays is passed \'true\' as argument, days have to be ordered based on locale first day of the week', function (assert) { | |||
| var deLocaleData = moment(); | |||
There was a problem hiding this comment.
nit/question: any reason we can't use const here?
There was a problem hiding this comment.
I think the rest of this library is written in ES5, but const was a ES2015 addition:
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/const
| var deLocaleData = moment(); | ||
| deLocaleData.locale('de'); | ||
|
|
||
| var neLocaleData = moment(); |
There was a problem hiding this comment.
same here, can we use const instead of var?
|
Thanks for opening this request. I instead merged #4553 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I debug and solved the issue #4783. Now it is possible to do
var deLocaleData = moment();deLocaleData.locale('de');deLocaleData.localeData().weekdays(true) // --> ['Montag', 'Dienstag', 'Mittwoch', 'Donnerstag', 'Freitag', 'Samstag', 'Sonntag']deLocaleData.localeData().weekdays() // --> ['Sonntag', 'Montag', 'Dienstag', 'Mittwoch', 'Donnerstag', 'Freitag', 'Samstag']Hopes this helps out! Bye