feat(createStoryMetaSettings): allow generating internal stories and autodocs page with metasettings helper #2079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…autodocs page with metasettings helper
YossiSaadi
commented
Apr 21, 2024
| @@ -34,9 +34,6 @@ const config: StorybookConfig = { | |||
| name: "@storybook/react-webpack5", | |||
| options: {} | |||
| }, | |||
| docs: { | |||
| autodocs: false | |||
There was a problem hiding this comment.
default is not true, default is tags, meaning only stories which define tags: ["autodocs"] would get autodocs page. It's good for internal components to get a "free" docs page
YossiSaadi
commented
Apr 21, 2024
packages/core/src/components/BaseInput/__stories__/BaseInput.stories.tsx
Outdated
Show resolved
Hide resolved
@talkor Can't determine why it fails. |
What fails? |
will leave it for now |
|
@talkor storybookjs/storybook#26940 |
oh no :/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: this PR is on hold, because of a bug from Storybook's side
This PR aims to manage the tags "backstage" for internal stories
It also enables creating autodocs page, with not much info (would mainly be used for internal components)