Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump 1st party deps to versions with available CodeQL scans #1989

Merged
merged 3 commits into from
May 14, 2024

Conversation

addaleax
Copy link
Contributor

No description provided.

"askcharacter": "^1.0.0",
"askpassword": "^1.2.4",
"askcharacter": "^2.0.4",
"askpassword": "^2.0.2",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Major version bumps because these included changes to the tested (= supported) Node.js versions. I stopped doing these after a bit because it turned out lots of packages needed updates 🙂

"mongodb-connection-string-url": "^3.0.0",
"mongodb-log-writer": "^1.4.0",
"mongodb-connection-string-url": "^3.0.1",
"mongodb-log-writer": "^1.4.2",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of these versions got bumped twice because it turns out that CodeQL jobs with cron workflow triggers get disabled after 60 days of no activity in a repo and I didn't know that when doing the first set of releases 😕

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

activity in the repo means commits to the main branch?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know, this is basically all the information available to me:

Screenshot 2024-05-10 at 21 12 42

"macos-export-certificate-and-key": "^1.1.1",
"mongodb-crypt-library-version": "^1.0.3",
"win-export-certificate-and-key": "^1.1.1"
"macos-export-certificate-and-key": "^1.1.2",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was almost driven insane by the "fact" that this bump of the library made CI fail even though no code changed (it surely can't be a coincidence, right, this PR bumps the package that provides the error message that's leading to the CI errors??), then finally thought to check other runs on main, turns out the CI redness happens completely independently of this PR without any code changes at all: #1991 🫠

@addaleax addaleax merged commit 992283a into main May 14, 2024
60 of 65 checks passed
@addaleax addaleax deleted the update-deps-to-codeql-scanned-versions branch May 14, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants