DRIVERS-1357: Add socks5srv.py helper script #181
Conversation
- Spec PR: mongodb/specifications#1103 - Node.js driver PR that makes use of this script: mongodb/node-mongodb-native#3041
| """Handle the Socks5 communication with a freshly connected client""" | ||
|
|
||
| # Client greeting | ||
| if self.request.recv(1) != b'\x05': # Socks5 only |
There was a problem hiding this comment.
Any request.recv/sendall call can raise an OSError exception, do you want to handle those explicitly or just let the thread fail with an exception? I think the latter is fine.
There was a problem hiding this comment.
Yeah, I’d also say so – I don’t really see a better alternative and I think this behavior is fine for our usage.
| with a, b: | ||
| while True: | ||
| try: | ||
| (readable, _, _) = select.select([a, b], [], []) |
There was a problem hiding this comment.
select will fail if the fd is > 1024 so we should prefer poll but since this is test only it's not a big deal. We're not planning to test this with >1000 connections are we?
There was a problem hiding this comment.
Also here, I agree that this is just fine for our usage – we are not planning to run this with more than 1000 connections at a time for sure :)
nbbeeken
changed the title
feat(NODE-3633): add Socks5 support mongodb/node-mongodb-native#3041