Test for server connection in EVG tests #443
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShaneHarvey
reviewed
Jun 4, 2024
Makefile
Outdated
| @@ -5,5 +5,6 @@ all: | |||
|
|
|||
| test: | |||
| @echo "Running tests..." | |||
| @if [ -n $(TEST_CONNECTION) ]; then $(MONGODB_BINARIES)/mongosh "$(MONGODB_URI)" --eval "db.runCommand({\"ping\":1})" --&serverSelectionTimeoutMS=10000; fi | |||
There was a problem hiding this comment.
Does this work for TLS clusters? (does MONGODB_URI include the TLS options?)
There was a problem hiding this comment.
We're running with Auth SSL in some of the tests that have run.
There was a problem hiding this comment.
I don't think it's working:
[2024/05/14 08:33:06.598] Current Mongosh Log ID: 66438432bc60e6820d5446fe
[2024/05/14 08:33:06.685] Connecting to: mongodb://<credentials>@localhost:27017,localhost:27018,localhost:27019/?authSource=admin&replicaSet=repl0&serverSelectionTimeoutMS=2000&appName=mongosh+2.1.1
[2024/05/14 08:33:08.713] MongoServerSelectionError: connection <monitor> to 127.0.0.1:27017 closed
[2024/05/14 08:33:08.713] Finished command 'shell.exec' in function 'run tests' (step 2 of 2) in 2.3270065s.
There was a problem hiding this comment.
As discussed in-person, I moved the tests to atlas and serverless setup, as well as the docker EVG test, since we are already testing connectivity with the servers launched with mongo-orchestration.
…ols into test-connections
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.