DRIVERS-2909 Add Env File Handling #444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blink1073
changed the title
Jibola
requested changes
May 28, 2024
Comment on lines
-344
to
-359
| "run serverless tests": | ||
| - command: shell.exec | ||
| type: test | ||
| params: | ||
| include_expansions_in_env: ["SERVERLESS_ATLAS_PASSWORD"] | ||
| working_dir: "src" | ||
| script: | | ||
| ${PREPARE_SHELL} | ||
| set +o xtrace | ||
| MONGODB_URI="${MONGODB_URI}" \ | ||
| SERVERLESS_ATLAS_USER="${SERVERLESS_ATLAS_USER}" \ | ||
| CRYPT_SHARED_LIB_PATH="${CRYPT_SHARED_LIB_PATH}" \ | ||
| bash ${PROJECT_DIRECTORY}/.evergreen/run-tests.sh | ||
|
|
||
| "run atlas tests": | ||
| - command: shell.exec |
There was a problem hiding this comment.
We no longer need these tests because we're deprecating serverless, right?
There was a problem hiding this comment.
This was a mistake, I need to uncomment this these tests. 😅
There was a problem hiding this comment.
Oh wait, I remember, we didn't need separate test commands for these anymore, they still get run from their respective task groups.
| ${PREPARE_SHELL} | ||
| set -ex | ||
| cd $DRIVERS_TOOLS/.evergreen/docker | ||
| ARCH=${ARCH} TARGET_IMAGE=${TARGET_IMAGE} MONGODB_VERSION=${MONGODB_VERSION} ENTRYPOINT=/root/test-entrypoint.sh bash run-server.sh |
There was a problem hiding this comment.
Same here. Do we need to put these as envs in the subprocess.exec?
Co-authored-by: Jib <Jibzade@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.