Revert "CLOUDP-237245: Add example for retrying requests " #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 5ded14a.
gssbzn
reviewed
Mar 28, 2024
| @@ -1,10 +1,10 @@ | |||
| module go.mongodb.org/atlas-sdk/v20231115008 | |||
|
|
|||
| go 1.22.1 | |||
| go 1.20 | |||
There was a problem hiding this comment.
why not only rollback this particular change?
There was a problem hiding this comment.
Updated description. We want to rollback whole change to make build pass.
blva
reviewed
Mar 28, 2024
There was a problem hiding this comment.
LGTM so I can close https://jira.mongodb.org/browse/CLOUDP-240011
gssbzn
approved these changes
Mar 28, 2024
blva
approved these changes
Mar 28, 2024
wtrocki
added a commit
that referenced
this pull request
Mar 28, 2024
)" This reverts commit 10f68c9.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #294 whole feature as we had done number of golang updates that are not compatibile lnternally. I will reintroduce change in follow up PR