Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(DOCSP-39429): Add support for Amazon Linux 2023 #369

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

(DOCSP-39429): Add support for Amazon Linux 2023 #369

wants to merge 1 commit into from

Conversation

davidhou17
Copy link
Collaborator

@davidhou17 davidhou17 commented May 9, 2024 •
edited

@blva Can we confirm that these are the correct commands?

Self-Review Checklist

  • Check that the submodule pulled in the right changes (if applicable).
  • Define taxonomy values at top of page.
  • Add genre facets (tutorial or reference), as in this example PR.
  • Add programmingLanguage (if necessary).
  • Add meta keywords (if necessary).
  • Resolve any new warnings or errors in the build.
  • Proofread for spelling and grammatical errors.
  • Check staging for rendering issues.
  • Confirm links are working.

@davidhou17 davidhou17 requested a review from blva May 9, 2024 17:40
blva
blva approved these changes May 22, 2024
View reviewed changes
source/install-atlas-cli.txt

[mongodb-org-{+mdbVersion+}]
name=MongoDB Repository
baseurl=https://repo.mongodb.org/yum/amazon/2023/mongodb-org/{+mdbVersion+}/x86_64/
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the instructions seem correct, however I can't find the atlas cli or mongodb-atlas available in the link, I'm checking if I can find how to get them there.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably this can only be merged after we do the release

zach-carr
zach-carr approved these changes May 22, 2024
View reviewed changes
Copy link
Collaborator

@zach-carr zach-carr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

zach-carr
zach-carr reviewed May 22, 2024
View reviewed changes
Copy link
Collaborator

@zach-carr zach-carr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, just noticed some errors in the build:

ERROR(command/atlas-completion-fish.txt:20ish): Unexpected indentation Did you mean: .. blockquote::
ERROR(command/atlas-completion-powershell.txt:20ish): Unexpected indentation

I don't think you introduced them but could you look into them? Defer to you if you can fix them or not

@davidhou17
Copy link
Collaborator Author

@zach-carr Ah, these are expected errors (see the bottom of https://wiki.corp.mongodb.com/display/DE/Atlas+CLI+Release+Checklist)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zach-carr zach-carr zach-carr approved these changes

@blva blva blva approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@davidhou17 @blva @zach-carr