-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PERF-5440 Fix created indices for ascending sort key queries in TimeSeriesLastpoint.yml workload #1219
Conversation
…eriesLastpoint.yml workload
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Yoonsoo, this looks great!
I left a few comments in #1218 which apply here.
Namely,
For AutoRun conditions
- can we remove the standalone conditions?
- should the branch conditional be "$gte: v7.0"?
It might be clearer to define active phases for the QuiesceActor within the workload file rather than the phases file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for review, @jawwadasghar!
can we remove the standalone conditions?
Definitely, removed.
should the branch conditional be "$gte: v7.0"?
This workload & related optimization has existed since v5.3. The reason why I set branch condition for the new workload to $gte: v7.0
is because it's a new one and we care about its perf against v7.0. It's not a part of high value workload. I changed this to $gte: v5.3
It might be clearer to define active phases for the QuiesceActor within the workload file rather than the phases file
done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks Yun-soo!
Jira Ticket: PERF-5440
Whats Changed
CrudActor
instead ofRunCommand
to execute the aggregatesOnlyActiveInPhases
Patch Testing Results
https://spruce.mongodb.com/version/663feee5e0ec0400072fd1cb/tasks?sorts=STATUS%3AASC%3BBASE_STATUS%3ADESC